Re: [PATCH 01/32] arm64: Add platform selection for BCM2835.
From: Florian Fainelli
Date: Thu Jun 02 2016 - 13:36:38 EST
On 06/02/2016 10:21 AM, Scott Branden wrote:
> On 16-06-02 10:12 AM, Gerd Hoffmann wrote:
>>> There is no need to add ARCH_BCM though?
>> There are Makefile(s) with
>> obj-$(CONFIG_ARCH_BCM) += bcm/
>> in drivers/pinctrl for example, maybe more, didn't check the whole tree.
>> So without ARCH_BCM some drivers are dropped from the build ...
> I see that now. Quite bizarre how the NS2 pinctl driver (used on a
> arm64 SoC) gets built right now....
> Yes, adding the select with hidden option seems like what needs to be
> done. The ARM Maintainers did not like multi-level ARCH_BCM being added
> in the arm64 Kconfig previously so we dropped it.
We should always recusrse into that directory and build the respective
pinctrl drivers within drivers/pinctrl/bcm, only for the enabled
platforms, it makes no sense to have this kind of config symbol gating that.
I can submit a patch doing just that unless somebody wants to do it as
part of this patch series.