Re: [PATCH 2/3] Update uv_bios_call to use efi_call_virt_generic
From: Alex Thorlton
Date: Thu Jun 02 2016 - 17:14:12 EST
On Thu, Jun 02, 2016 at 08:45:47PM +0100, Matt Fleming wrote:
> Unless I've missed it, I didn't see an explanation in the changelog of
> why it's OK to switch from using __va(tab->function) to tab->function
> directly, which presumably is a physical address.
> Was that intended?
It was intended. The motivation is so that we can use the same
"dereference the pointer inside the macro" stuff that we do with the
efi.systab->runtime pointer. IINM, the reason it works is because we do
* Make sure the 1:1 mappings are present as a catch-all for b0rked
* firmware which doesn't update all internal pointers after switching
* to virtual mode and would otherwise crap on us.
Inside of efi_map_region, so we know we'll have that physical address
mapped into the EFI page table.
Upon review, I'm wondering if the correct thing to do here is to
update that pointer during the switch to virtual mode, to avoid the
b0rkage mentioned in the above comment.
Either way, the straigh tab->function dereference should work while
using the EFI page table, but I do wonder if that tab->function address
should have been updated to the __va() version of itself before we reach
Maybe you can comment on that?