Re: [PATCH 17/20] x86, mmc: use Intel family name macros for mmc driver

From: Ulf Hansson
Date: Fri Jun 03 2016 - 03:42:44 EST


On 2 June 2016 at 02:12, Dave Hansen <dave@xxxxxxxx> wrote:
>
> From: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
>
> Another straightforward replacement of magic numbers.
>
> Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: linux-mmc@xxxxxxxxxxxxxxx

Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

I assume you are going to queue this via the x86 tree or whatever tree
that makes sense!?

Kind regards
Uffe

> ---
>
> b/drivers/mmc/host/sdhci-acpi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -puN drivers/mmc/host/sdhci-acpi.c~x86-intel-families-sdhci-acpi drivers/mmc/host/sdhci-acpi.c
> --- a/drivers/mmc/host/sdhci-acpi.c~x86-intel-families-sdhci-acpi 2016-06-01 15:45:09.826201501 -0700
> +++ b/drivers/mmc/host/sdhci-acpi.c 2016-06-01 15:45:09.830201683 -0700
> @@ -43,6 +43,7 @@
>
> #ifdef CONFIG_X86
> #include <asm/cpu_device_id.h>
> +#include <asm/intel-family.h>
> #include <asm/iosf_mbi.h>
> #endif
>
> @@ -126,7 +127,7 @@ static const struct sdhci_acpi_chip sdhc
> static bool sdhci_acpi_byt(void)
> {
> static const struct x86_cpu_id byt[] = {
> - { X86_VENDOR_INTEL, 6, 0x37 },
> + { X86_VENDOR_INTEL, 6, INTEL_FAM6_MODEL_ATOM_SILVERMONT1 },
> {}
> };
>
> _