Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.
From: Arnd Bergmann
Date: Fri Jun 03 2016 - 04:43:01 EST
On Thursday, June 2, 2016 11:12:38 AM CEST Eric Anholt wrote:
> Arnd Bergmann <arnd@xxxxxxxx> writes:
> > On Wednesday, June 1, 2016 11:43:30 PM CEST Gerd Hoffmann wrote:
> >> + /* Parse OF address directly to get the physical address for
> >> + * DMA to our registers.
> >> + */
> >> + host->phys_addr = be32_to_cpup(of_get_address(pdev->dev.of_node, 0,
> >> + NULL, NULL));
> > This looks broken on 64-bit systems when #address-cells=<2>, or if there
> > is an intermediate bus with a non-empty ranges property.
> > What's wrong with platform_get_resource(pdev, IORESOURCE_MEM, 0)?
> I'll get to the rest of the review later, but this is a weird pattern
> that we have in several bcm2835-related drivers.
> We need the address as seen by the DMA controller, not the address from
> the ARM's perspective (which is offset by the dma-ranges DT property).
> This is the way that people have figured out to get that address.
I see. This is indeed a bit tricky, as there is no easy way to know
how the dmaengine is wired up to the slave. A correct solution is
probably to follow the 'dma-ranges' up from the master to the common
parent and then follow the 'ranges' back to the slave, but that
requires coming up with a new exported function.
It's perhaps good enough in the meantime to read out the address from
the slave directly, but you should not assume that the first
cell has the complete information and instead should at least