RE: [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support

[Pramod Kumar]

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@xxxxxxx]
> Sent: 01 June 2016 18:42
> To: Pramod Kumar
> Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala;
Catalin
> Marinas; Will Deacon; Kishon Vijay Abraham I; David S. Miller;
> devicetree@xxxxxxxxxxxxxxx; Jon Mason; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; bcm-kernel-feedback-list@xxxxxxxxxxxx;
linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support
>
> > +static int ns2_pci_phy_probe(struct mdio_device *mdiodev) {
> > +	struct device *dev = &mdiodev->dev;
> > +	struct phy_provider *provider;
> > +	struct ns2_pci_phy *p;
> > +	struct phy *phy;
> > +
> > +	phy = devm_phy_create(dev, dev->of_node, &ns2_pci_phy_ops);
> > +	if (IS_ERR_OR_NULL(phy)) {
> > +		dev_err(dev, "failed to create Phy\n");
> > +		return PTR_ERR(phy);
> > +	}
>
> https://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg78030.html
>

I've explored inside this API and see it never returning NULL. I'll
replace IS_ERR_OR_NULL to IS_ERR.
Thanks for pointing this out.

> 	Andrew

Regards,
Pramod