Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t
From: Peter Zijlstra
Date: Fri Jun 03 2016 - 08:01:25 EST
On Fri, Jun 03, 2016 at 10:04:07AM +0200, Ingo Molnar wrote:
> So I tried to pick up this series, and it broke the Alpha and IA64 builds:
> /home/mingo/tip/arch/ia64/include/asm/rwsem.h: In function '___down_write':
> /home/mingo/tip/arch/ia64/include/asm/rwsem.h:58:7: error: incompatible types when
> assigning to type 'long int' from type 'atomic_long_t'
> old = sem->count;
> home/mingo/tip/arch/alpha/include/asm/rwsem.h: In function '__down_read':
> /home/mingo/tip/arch/alpha/include/asm/rwsem.h:28:11: error: incompatible types
> when assigning to type 'long int' from type 'atomic_long_t'
> oldcount = sem->count;
Yeah, that's intermediate borkage, the easiest fix would be to just fold
the two patches. Let me do that and verify it builds properly.
> btw., for some reason I don't have the mails from Jason in my mbox, perhaps GMail
> spam filtering ate it?
Linus has been complaining about a lot of lost email due to gmail's idea
of what constitutes spam, so that's entirely possible.