Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

From: Laxman Dewangan
Date: Fri Jun 03 2016 - 08:15:55 EST

On Friday 03 June 2016 05:34 PM, Jonathan Cameron wrote:
On 03/06/16 12:31, Laxman Dewangan wrote:
On Friday 03 June 2016 03:46 PM, Jonathan Cameron wrote:
On 03/06/16 11:06, Jonathan Cameron wrote:
Code looks good, bu these more fundamental bits need sorting.
Another minor point - why do the power calculations in driver?
no hardware support for it, so why not just leave it to userspace?
Device supports the bus and shunt voltage monitoring. So even no current. Also the warning/critical limit is for the voltage across shunt.

So should we only expose the shunt/bus voltage, no power/current?

I am thinking that user space should not know the platform and hence shunt resistance and so exposing the current and power on bus is better option.

I'd go for current and voltage rather than current and power, but
otherwise agree.

OK, I will have the voltage (bus voltage) and current (on bus).
User space can get power out of this.

Thanks for suggestion.

The critical limits will be still in current. And it should be customized sysfs instead of the iio_chan_spec i.e. iio_device attribute interface.