Re: [PATCH 1/3] ntb_perf: Allow limiting the size of the memory windows

From: Jiang, Dave
Date: Fri Jun 03 2016 - 17:04:17 EST


On Fri, 2016-06-03 at 14:50 -0600, Logan Gunthorpe wrote:
> On my system, dma_alloc_coherent won't produce memory anywhere
> near the size of the BAR. So I needed a way to limit this.
>
> It's pretty much copied straight from ntb_transport.
>
> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
Acked-by: Dave Jiang <dave.jiang@xxxxxxxxx>

> ---
> Âdrivers/ntb/test/ntb_perf.c | 8 ++++++++
> Â1 file changed, 8 insertions(+)
>
> diff --git a/drivers/ntb/test/ntb_perf.c
> b/drivers/ntb/test/ntb_perf.c
> index 8dfce9c..30635c8 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -83,6 +83,10 @@ MODULE_DESCRIPTION(DRIVER_DESCRIPTION);
> Â
> Âstatic struct dentry *perf_debugfs_dir;
> Â
> +static unsigned long max_mw_size;
> +module_param(max_mw_size, ulong, 0644);
> +MODULE_PARM_DESC(max_mw_size, "Limit size of large memory windows");
> +
> Âstatic unsigned int seg_order = 19; /* 512K */
> Âmodule_param(seg_order, uint, 0644);
> ÂMODULE_PARM_DESC(seg_order, "size order [n^2] of buffer segment for
> testing");
> @@ -472,6 +476,10 @@ static void perf_link_work(struct work_struct
> *work)
> Â dev_dbg(&perf->ntb->pdev->dev, "%s called\n", __func__);
> Â
> Â size = perf->mw.phys_size;
> +
> + if (max_mw_size && size > max_mw_size)
> + size = max_mw_size;
> +
> Â ntb_peer_spad_write(ndev, MW_SZ_HIGH, upper_32_bits(size));
> Â ntb_peer_spad_write(ndev, MW_SZ_LOW, lower_32_bits(size));
> Â ntb_peer_spad_write(ndev, VERSION, PERF_VERSION);
> --Â
> 2.1.4
>