Re: [PATCH] tty: serial: msm: Don't read off end of tx fifo

From: Stephen Boyd
Date: Fri Jun 03 2016 - 20:04:04 EST

On 06/02, Bjorn Andersson wrote:
> For dm uarts in pio mode tx data is transferred to the fifo register 4
> bytes at a time, but care is not taken when these 4 bytes spans the end
> of the xmit buffer so the loop might read up to 3 bytes past the buffer
> and then skip the actual data at the beginning of the buffer.
> Fix this by, analogous to the DMA case, make sure the chunk doesn't
> wrap the xmit buffer.
> Fixes: 3a878c430fd6 ("tty: serial: msm: Add TX DMA support")
> Cc: Andy Gross <andy.gross@xxxxxxxxxx>
> Cc: Ivan Ivanov <iivanov.xz@xxxxxxxxx>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: Frank Rowand <frowand.list@xxxxxxxxx>
> Reported-by: Nicolas Dechesne <nicolas.dechesne@xxxxxxxxxx>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> ---

Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project