Re: [PATCH v2 1/1] rtc: ds1685: correct check of day of month
From: Alexandre Belloni
Date: Sat Jun 04 2016 - 09:47:14 EST
On 22/05/2016 at 00:18:55 +0200, Heinrich Schuchardt wrote :
> The day of month is checked in ds1685_rtc_read_alarm
> and ds1685_rtc_set_alarm.
> Multiple errors exist in the day of month check.
> Operator ! has a higher priority than &&.
> (!(mday >= 1) && (mday <= 31)) is false for mday == 32.
> When verifying the day of month the binary and the BCD mode
> have to be considered.
> consider ds1685_rtc_read_alarm
> consider rtc->bcd_mode as indicated by Alexandre Belloni
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@xxxxxx>
> drivers/rtc/rtc-ds1685.c | 34 +++++++++++++++++++++++++++++-----
> 1 file changed, 29 insertions(+), 5 deletions(-)
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering