Re: [PATCH] documentation: ntb.txt correct grammar "however"
From: Ken Moffat
Date: Sat Jun 04 2016 - 21:36:26 EST
On Sat, Jun 04, 2016 at 03:34:01PM -0400, Justin Keller wrote:
> Correct the grammar around the word however.
> Signed-off-by: Justin Keller <justincompsci@xxxxxxxxx>
> index 1d9bbab..5d43510 100644
> --- a/Documentation/ntb.txt
> +++ b/Documentation/ntb.txt
> @@ -35,7 +35,7 @@ establishes a logical link to the peer, and creates queue pairs to exchange
> messages and data. The NTB Netdev then creates an ethernet device using a
> Transport queue pair. Network data is copied between socket buffers and the
> Transport queue pair buffer. The Transport client may be used for other things
> -besides Netdev, however no other applications have yet been written.
> +besides Netdev; however, no other applications have yet been written.
> ### NTB Ping Pong Test Client (ntb\_pingpong)
As a user of British English, the original looks fine. Your change,
however, looks odd - a semi-colon seems out of place. If you
replaced it by a full-stop it would look acceptable to me - but not
in any sense better than what is there at the moment.
I had to walk fifteen miles to school, barefoot in the snow. Uphill both ways.