Re: [PATCH] net: ethernet: cavium: liquidio: response_manager: Remove create_workqueue
From: Tejun Heo
Date: Sun Jun 05 2016 - 06:24:41 EST
On Sat, Jun 04, 2016 at 08:21:40PM +0530, Bhaktipriya Shridhar wrote:
> alloc_workqueue replaces deprecated create_workqueue().
> A dedicated workqueue has been used since the workitem viz
> (&cwq->wk.work which maps to oct_poll_req_completion) is involved
> in normal device operation. WQ_MEM_RECLAIM has been set to guarantee
> forward progress under memory pressure, which is a requirement here.
> Since there are only a fixed number of work items, explicit concurrency
> limit is unnecessary.
> flush_workqueue is unnecessary since destroy_workqueue() itself calls
> drain_workqueue() which flushes repeatedly till the workqueue
> becomes empty. Hence the call to flush_workqueue() has been dropped.
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@xxxxxxxxx>
As with the previous patch, the subject tag doesn't need to contain
the full hierarchy but other than that,
Acked-by: Tejun Heo <tj@xxxxxxxxxx>