Re: [PATCH] net: ethernet: cavium: liquidio: request_manager: Remove create_workqueue

From: Tejun Heo
Date: Sun Jun 05 2016 - 06:26:11 EST


On Sat, Jun 04, 2016 at 08:54:00PM +0530, Bhaktipriya Shridhar wrote:
> diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> index a2a2465..9313915 100644
> --- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
> +++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> @@ -144,7 +144,9 @@ int octeon_init_instr_queue(struct octeon_device *oct,
>
> oct->fn_list.setup_iq_regs(oct, iq_no);
>
> - oct->check_db_wq[iq_no].wq = create_workqueue("check_iq_db");
> + oct->check_db_wq[iq_no].wq = alloc_workqueue("check_iq_db",
> + WQ_MEM_RECLAIM,
> + 0);

Why the new line between WQ_MEM_RECLAIM and 0?

Except for the subj tag and the above nit,

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun