Re: [PATCH 1/4] irtl8188eu: Replace semaphore cmd_queue_sema with completion

From: Larry Finger
Date: Sun Jun 05 2016 - 12:32:39 EST

On 06/03/2016 04:59 AM, Binoy Jayan wrote:
The semaphore 'cmd_queue_sema' is used as completion,
so convert it to struct completion.

Signed-off-by: Binoy Jayan <binoy.jayan@xxxxxxxxxx>

The subject for this patch has a misplaced "i" at the beginning courtesy of vi.

One other point, it is customary to start the patch subject with "staging: rtl8188eu: ..." for drivers in staging. I also prefer using r8188eu rather than rtl8188eu as the former is the actual name of the driver, but either will work.

I have tested all 4 of these patches with no problems, thus

Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

As you may have noted, my testing of the modified driver has resulted in some additional fixes for various problems including a system panic caused by an ill-advised and untested change.