[PATCH 4.6 071/121] PKCS#7: fix missing break on OID_sha224 case

From: Greg Kroah-Hartman
Date: Sun Jun 05 2016 - 17:56:46 EST

4.6-stable review patch. If anyone has any objections, please let me know.


From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

commit 06af9b0f4949b85b20107e6d75f5eba15111d220 upstream.

The OID_sha224 case is missing a break and it falls through
to the -ENOPKG error default. Since HASH_ALGO_SHA224 seems
to be supported, this looks like an unintentional missing break.

Fixes: 07f081fb5057 ("PKCS#7: Add OIDs for sha224, sha284 and sha512 hash algos and use them")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

crypto/asymmetric_keys/pkcs7_parser.c | 1 +
1 file changed, 1 insertion(+)

--- a/crypto/asymmetric_keys/pkcs7_parser.c
+++ b/crypto/asymmetric_keys/pkcs7_parser.c
@@ -237,6 +237,7 @@ int pkcs7_sig_note_digest_algo(void *con
case OID_sha224:
ctx->sinfo->sig.hash_algo = "sha224";
+ break;
printk("Unsupported digest algo: %u\n", ctx->last_oid);
return -ENOPKG;