Re: [PATCH V3] watchdog: max77620: Add support for watchdog timer

[Guenter Roeck]

On 06/08/2016 06:39 AM, Laxman Dewangan wrote:
> Maxim PMIC MAX77620 is Power management IC which have multiple
> sub blocks like regulators (DCDC/LDOs), GPIO, RTC, Clock, Watchdog
> timer etc.
>
> Add the driver for watchdog timer under watchdog framework.
> The driver implements the watchdog callbacks to start, stop,
> ping and set timeout for watchodg framework.
>
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>

Mostly good.

[ ... ]

> +	/* Check if WDT running and ig yes then set flags properly */

s/ig/if/

Please fix this up and resend, with

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Can you by any chance send me a copy of the datasheet ? I wanted to look up the
chip default for the watchdog timeout and realized that the chip does not
officially exist.

Thanks,
Guenter