Re: [PATCH] mfd: omap-usb-tll: fix include of omap-usb.h

From: Lee Jones
Date: Thu Jun 09 2016 - 09:51:59 EST


On Wed, 08 Jun 2016, Ben Dooks wrote:

> Fix the warnings about the following functions not being
> declared by including omap-usb.h which declares them:
>
> drivers/mfd/omap-usb-tll.c:333:5: warning: symbol 'omap_tll_init' was not declared. Should it be static?
> drivers/mfd/omap-usb-tll.c:408:5: warning: symbol 'omap_tll_enable' was not declared. Should it be static?
> drivers/mfd/omap-usb-tll.c:442:5: warning: symbol 'omap_tll_disable' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> ---
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
> drivers/mfd/omap-usb-tll.c | 2 ++
> 1 file changed, 2 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> index c30290f..1aa74c4 100644
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -30,6 +30,8 @@
> #include <linux/platform_data/usb-omap.h>
> #include <linux/of.h>
>
> +#include "omap-usb.h"
> +
> #define USBTLL_DRIVER_NAME "usbhs_tll"
>
> /* TLL Register Set */

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog