Re: [PATCH v4] udp reuseport: fix packet of same flow hashed to different socket

From: Eric Dumazet
Date: Sun Jun 12 2016 - 23:13:39 EST


On Mon, 2016-06-13 at 11:02 +0800, Su Xuemin wrote:
> From: "Su, Xuemin" <suxm@xxxxxxxxxxxxxxxxxx>
>
> There is a corner case in which udp packets belonging to a same
> flow are hashed to different socket when hslot->count changes from 10
> to 11:
...
> Signed-off-by: Su, Xuemin <suxm@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> ---
> I use this tree to generate the patch:
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>
> net/ipv4/udp.c | 73 +++++++++++++---------------------------------------------
> net/ipv6/udp.c | 71 +++++++++++++-------------------------------------------
> 2 files changed, 32 insertions(+), 112 deletions(-)

Very nice simplification of UDP stack, thanks a lot for finalizing this.