Re: [PATCH 0/8] kexec_file_load implementation for PowerPC

From: Dave Young
Date: Mon Jun 13 2016 - 03:03:09 EST


On 06/12/16 at 12:10am, Thiago Jung Bauermann wrote:
> Hello,
>
> This patch series implements the kexec_file_load system call on PowerPC.
>
> It starts by removing an x86 assumption from kexec_file: kexec_add_buffer uses
> iomem to find reserved memory ranges, but PowerPC uses the memblock subsystem.
> Hooks are added so that each arch can specify how memory ranges can be found.
>
> Also, the memory-walking logic in kexec_add_buffer is useful in this
> implementation to find a free area for the purgatory's stack, so that same
> patch moves that logic to kexec_locate_mem_hole.
>
> The kexec_file_load system call needs to apply relocations to the purgatory
> but adding code for that would duplicate functionality with the module loading
> mechanism, which also needs to apply relocations to the kernel modules.
> Therefore, this patch series factors out the module relocation code so that it
> can be shared.
>
> One thing that is still missing is crashkernel support, which I intend to
> submit shortly.

But seems there's no error handling in patches about KEXEC_ON_CRASH?
It would be good to either sending out the whole set or handle the error
cases correctly.

[snip]

Thanks
Dave