Re: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node

[Kevin Hilman]

Hi Neil,

Neil Armstrong <narmstrong@xxxxxxxxxxxx> writes:

> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 832815d..8353621 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -167,6 +167,11 @@
>  			};
>  		};
>  
> +		rng {
> +			compatible = "amlogic,meson-rng";
> +			reg = <0x0 0xc8834000 0x0 0x4>;
> +		};

This should be under the periphs bus, with an offset of 0x0 instead of
at the top level.

See the for-next branch in the linux-amlogic tree[1] which has separate
busses for periphs and hiu.

Kevin

[1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git