Re: [alsa-devel] [PATCH v2 2/2] sound: lpass-platform: Move dma channel allocation to pcmops

From: Kenneth Westfield
Date: Tue Jun 14 2016 - 12:33:15 EST


On Tue, Jun 14, 2016 at 06:34:50AM -0700, Srinivas Kandagatla wrote:
> On 14/06/16 13:49, Kenneth Westfield wrote:
> >On Tue, Jun 14, 2016 at 09:30:03AM +0100, Srinivas Kandagatla wrote:

> >>- data = devm_kzalloc(soc_runtime->dev, sizeof(*data), GFP_KERNEL);
> >>+ data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> >
> >Is the reason for changing the dev pointer similar to why it was changed
> >for snd_dma_alloc_pages() below?
> Yep, Only reason is that I can fit stuff in single line.

The original line fit in one as well. If that is the reason, maybe
just leave it unchanged.

--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project