Re: [PATCH v2 1/2] liblockdep: Fix compile errors

From: Sasha Levin
Date: Tue Jun 14 2016 - 14:45:04 EST


On 06/14/2016 06:49 AM, Vishal Thanki wrote:
> diff --git a/tools/lib/lockdep/uinclude/linux/jhash.h b/tools/lib/lockdep/uinclude/linux/jhash.h
> new file mode 100644
> index 0000000..348c6f4
> --- /dev/null
> +++ b/tools/lib/lockdep/uinclude/linux/jhash.h
> @@ -0,0 +1,175 @@
> +#ifndef _LINUX_JHASH_H

Oh, we don't need to copy the whole thing. I was thinking about something like:

diff --git a/tools/lib/lockdep/uinclude/linux/unaligned/packed_struct.h b/tools/lib/lockdep/uinclude/linux/unaligned/packed_struct.h
new file mode 100644
index 0000000..7b204fc
--- /dev/null
+++ b/tools/lib/lockdep/uinclude/linux/unaligned/packed_struct.h
@@ -0,0 +1,2 @@
+#include "../../../include/linux/unaligned/packed_struct.h"

for both packed_struct.h and jhash.h. This was we get the advantage of having any
fixes to those headers automatically go into liblockdep as well.


Thanks,
Sasha