Re: [PATCH] mdio: mux: avoid 'maybe-uninitialized' warning

From: Andrew Lunn
Date: Tue Jun 14 2016 - 16:55:26 EST


On Tue, Jun 14, 2016 at 12:03:17PM +0200, Arnd Bergmann wrote:
> The latest changes to the MDIO code introduced a false-positive
> warning with gcc-6 (possibly others):
>
> drivers/net/phy/mdio-mux.c: In function 'mdio_mux_init':
> drivers/net/phy/mdio-mux.c:188:3: error: 'parent_bus_node' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> It's easy to avoid the warning by making sure the parent_bus_node
> is initialized in both cases at the start of the function, since
> the later 'of_node_put()' call is also valid for a NULL pointer
> argument.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: f20e6657a875 ("mdio: mux: Enhanced MDIO mux framework for integrated multiplexers")

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Thanks Arnd

Andrew