[PATCH 1/1] usb: core: of.c: fix defined but not declare warning

From: Peter Chen
Date: Wed Jun 15 2016 - 00:32:22 EST


The helper usb_of_get_child_node is defined at of.c, but missing its
declare as a global function. Fix it by adding related header file
as well as compile it on conditional of CONFIG_OF.

Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Cc: Arnd Bergmann <arnd@xxxxxxxx>
Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
Cc: linux-usb@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxxxxxxxx

Signed-off-by: Peter Chen <peter.chen@xxxxxxx>
Reported-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
---
drivers/usb/core/Makefile | 3 ++-
drivers/usb/core/of.c | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/core/Makefile b/drivers/usb/core/Makefile
index 9780877..da36b78 100644
--- a/drivers/usb/core/Makefile
+++ b/drivers/usb/core/Makefile
@@ -5,8 +5,9 @@
usbcore-y := usb.o hub.o hcd.o urb.o message.o driver.o
usbcore-y += config.o file.o buffer.o sysfs.o endpoint.o
usbcore-y += devio.o notify.o generic.o quirks.o devices.o
-usbcore-y += port.o of.o
+usbcore-y += port.o

+usbcore-$(CONFIG_OF) += of.o
usbcore-$(CONFIG_PCI) += hcd-pci.o
usbcore-$(CONFIG_ACPI) += usb-acpi.o

diff --git a/drivers/usb/core/of.c b/drivers/usb/core/of.c
index 2289700..3de4f88 100644
--- a/drivers/usb/core/of.c
+++ b/drivers/usb/core/of.c
@@ -18,6 +18,7 @@
*/

#include <linux/of.h>
+#include <linux/usb/of.h>

/**
* usb_of_get_child_node - Find the device node match port number
--
1.9.1