Re: [PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on Edison

From: Ingo Molnar
Date: Wed Jun 15 2016 - 04:07:09 EST



* Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> +static const struct devs_id pcal9555a_1_dev_id __initconst = {
> + .name = "pcal9555a-1",
> + .type = SFI_DEV_TYPE_I2C,
> + .delay = 1,
> + .get_platform_data = &pcal9555a_platform_data,
> +};
> +
> +static const struct devs_id pcal9555a_2_dev_id __initconst = {
> + .name = "pcal9555a-2",
> + .type = SFI_DEV_TYPE_I2C,
> + .delay = 1,
> + .get_platform_data = &pcal9555a_platform_data,
> +};
> +
> +static const struct devs_id pcal9555a_3_dev_id __initconst = {
> + .name = "pcal9555a-3",
> + .type = SFI_DEV_TYPE_I2C,
> + .delay = 1,
> + .get_platform_data = &pcal9555a_platform_data,
> +};
> +
> +static const struct devs_id pcal9555a_4_dev_id __initconst = {
> + .name = "pcal9555a-4",
> + .type = SFI_DEV_TYPE_I2C,
> + .delay = 1,
> + .get_platform_data = &pcal9555a_platform_data,
> +};

I have the same complaint as yesterday. Going forward could we please get nice
structure initializers in all future patches? :)

Thanks,

Ingo