Re: [PATCH 5/7] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data

[Benjamin Tissoires]

On Jun 03 2016 or thereabouts, Andrew Duggan wrote:
> The pointer to struct rmi_function in f12_data is never set and was never
> used. The fn pointer is also stored in rmi_2d_sensor which is a member of
> f12_data.
> 
> Signed-off-by: Andrew Duggan <aduggan@xxxxxxxxxxxxx>
> ---

If it compiles, you are OK :)

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

Cheers,
Benjamin


>  drivers/input/rmi4/rmi_f12.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
> index 041a91d..7d66766 100644
> --- a/drivers/input/rmi4/rmi_f12.c
> +++ b/drivers/input/rmi4/rmi_f12.c
> @@ -27,7 +27,6 @@ enum rmi_f12_object_type {
>  };
>  
>  struct f12_data {
> -	struct rmi_function *fn;
>  	struct rmi_2d_sensor sensor;
>  	struct rmi_2d_sensor_platform_data sensor_pdata;
>  	bool has_dribble;
> -- 
> 2.5.0
>