Re: linux-4.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c: 2 * pointless tests ?

[David Binderman]

Hello there,

>yup, looks like we can drop the two pipe<0 checks.

Righto.

>Care to send a patch?

Oh dear. My success rate with patches is near zero. Maybe something
like this might be suitable:

*** linux-3.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c.sav
2016-06-15 10:58:04.868619030 +0100
--- linux-4.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c   2016-06-15
10:58:25.401942157 +0100
***************
*** 542,548 ****
    struct msm_drm_private *priv = dev->dev_private;
    struct drm_crtc *crtc;

!   if (pipe < 0 || pipe >= priv->num_crtcs) {
        DRM_ERROR("Invalid crtc %d\n", pipe);
        return -EINVAL;
    }
--- 542,548 ----
    struct msm_drm_private *priv = dev->dev_private;
    struct drm_crtc *crtc;

!   if (pipe >= priv->num_crtcs) {
        DRM_ERROR("Invalid crtc %d\n", pipe);
        return -EINVAL;
    }
***************
*** 564,570 ****
    struct drm_crtc *crtc;
    struct drm_encoder *encoder;

!   if (pipe < 0 || pipe >= priv->num_crtcs)
        return 0;

    crtc = priv->crtcs[pipe];
--- 564,570 ----
    struct drm_crtc *crtc;
    struct drm_encoder *encoder;

!   if (pipe >= priv->num_crtcs)
        return 0;

    crtc = priv->crtcs[pipe];

Feel free to mess this tentative patch about in any way you see fit.


Regards

David Binderman


On Mon, Jun 13, 2016 at 4:27 PM, Rob Clark <robdclark@xxxxxxxxx> wrote:
> yup, looks like we can drop the two pipe<0 checks.  Care to send a patch?
>
> BR,
> -R
>
> On Mon, Jun 13, 2016 at 10:51 AM, David Binderman
> <linuxdev.baldrick@xxxxxxxxx> wrote:
>> Hello there,
>>
>> 1.
>>
>> linux-4.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c:545]: (style)
>> Checking if unsigned variable 'pipe' is less than zero.
>>
>> Source code is
>>
>>     if (pipe < 0 || pipe >= priv->num_crtcs) {
>>
>> 2.
>>
>> linux-4.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c:567]: (style)
>> Checking if unsigned variable 'pipe' is less than zero.
>>
>> Duplicate a few lines further down.
>>
>>
>> Regards
>>
>> David Binderman