Re: [PATCH] reiserfs: avoid uninitialized variable use

From: Arnd Bergmann
Date: Wed Jun 15 2016 - 08:13:53 EST


On Wednesday, June 15, 2016 11:06:06 AM CEST Paul Bolle wrote:
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > ---
> > I thought I had send this on May 12 when I first became aware of
> > the warning, but I can't find a reference to that now on any
> > mailing list archives, and I'm not sure who is picking up
> > reiserfs patches these days.
> >
> > The warning is now one of the few 'allmodconfig' warnings for
> > arm64 and possibly some other architectures.
>
> x86 and x86_64 are two of those architectures. This patch silences the
> warning on those architectures too.
>
> (I wouldn't dare to say whether the patch is correct. I've looked at
> this warning quite a few times in the last year and found the code hard
> to grok. It's impressive that you managed to come up with an actual
> fix.)

Jan Kara has shown that my patch is completely wrong, and Jeff Mahoney
sent a correct one that is now in linux-next.

Arnd