Re: [RFC PATCH] tty: serial: msm_serial: Don't reset uart on set_termios

From: Pramod Gurav
Date: Wed Jun 15 2016 - 08:58:25 EST


On 14 June 2016 at 00:32, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote:
> Upon opening the tty, uart_open() ends up calling msm_set_baud_rate()
> which resets the uart block. If this happens as we're coming out of
> msm_console_write() a full fifo worth of console output will be
> discarded.
>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> ---
>
> As reported here:
> https://bugs.96boards.org/show_bug.cgi?id=378
>
> drivers/tty/serial/msm_serial.c | 18 ------------------
> 1 file changed, 18 deletions(-)

Thanks for the patch.

I no longer see these corruptions with this patch. This is what I used
to see on my DB410C with debain FS:
http://paste.ubuntu.com/17319106/

Tested-by: Pramod Gurav <pramod.gurav@xxxxxxxxxx>

Regards,
Pramod