RE: [PATCH v2] Linux VM workaround for Knights Landing A/D leak

From: Anaczkowski, Lukasz
Date: Wed Jun 15 2016 - 09:13:11 EST


From: Nadav Amit [mailto:nadav.amit@xxxxxxxxx]
Sent: Tuesday, June 14, 2016 8:38 PM

>> + pte_t pte = ptep_get_and_clear(mm, addr, ptep);
>> +
>> + if (boot_cpu_has_bug(X86_BUG_PTE_LEAK))
>> + fix_pte_leak(mm, addr, ptep);
>> + return pte;
>> }
>
> I missed it on the previous iteration: ptep_get_and_clear already calls
> fix_pte_leak when needed. So do you need to call it again here?

You're right, Nadav. Not needing this. Will be removed in next version of the patch.

Cheers,
Lukasz