Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks

From: Javier Martinez Canillas
Date: Wed Jun 15 2016 - 11:28:09 EST


Hello Laxman,

On 06/15/2016 10:13 AM, Laxman Dewangan wrote:
> Maxim Max77620 has one 32KHz clock output and the clock HW
> IP used on this PMIC is same as what it is there in the MAX77686.
>
> Add clock driver support for MAX77620 on the MAX77686 driver.
>
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> CC: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> CC: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
> ---
> drivers/clk/Kconfig | 7 ++++---
> drivers/clk/clk-max77686.c | 16 ++++++++++++++++
> 2 files changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 6afad74..d75f4c5 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -32,10 +32,11 @@ config COMMON_CLK_WM831X
> source "drivers/clk/versatile/Kconfig"
>
> config COMMON_CLK_MAX77686
> - tristate "Clock driver for Maxim 77686/77802 MFD"
> - depends on MFD_MAX77686
> + tristate "Clock driver for Maxim 77686/77802/MAX77620 MFD"
> + depends on MFD_MAX77686 || MFD_MAX77620
> ---help---
> - This driver supports Maxim 77686/77802 crystal oscillator clock.
> + This driver supports Maxim 77686/77802/MAX77620 crystal oscillator

s/MAX77620/77620

Besides this minor nit, the patch looks good to me:

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America