Re: [PATCH v3 2/2] reset: add a SYSCON based reset driver

From: Andrew F. Davis
Date: Wed Jun 15 2016 - 12:53:18 EST


On 06/15/2016 11:51 AM, Suman Anna wrote:
> Hi Andrew,
>
> On 06/01/2016 01:41 PM, Andrew F. Davis wrote:
>> Add a reset-controller driver for performing reset management of
>> various devices present on the SoC, with the reset registers shared
>> between devices in a common register memory space. This driver uses
>> the syscon/regmap frameworks to actually implement the various reset
>> functionalities needed by the reset consumer devices.
>>
>> Signed-off-by: Andrew F. Davis <afd@xxxxxx>
>> [s-anna@xxxxxx: add documentation, syscon name change]
>> Signed-off-by: Suman Anna <s-anna@xxxxxx>
>> ---
>> drivers/reset/Kconfig | 10 ++
>> drivers/reset/Makefile | 1 +
>> drivers/reset/reset-syscon.c | 289 +++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 300 insertions(+)
>> create mode 100644 drivers/reset/reset-syscon.c
>>
>> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
>> index 0b2733d..73072e2 100644
>> --- a/drivers/reset/Kconfig
>> +++ b/drivers/reset/Kconfig
>> @@ -15,5 +15,15 @@ menuconfig RESET_CONTROLLER
>> config RESET_OXNAS
>> bool
>>
>> +config SYSCON_RESET
>> + tristate "SYSCON Reset Driver"
>> + depends on RESET_CONTROLLER
>
> Please add a depends on HAS_IOMEM here that you seem to have missed from
> our local patches.
>

Will add for v4.

Thanks,
Andrew