Re: [PATCH v3 2/4] Add the latent_entropy gcc plugin

From: Kees Cook
Date: Wed Jun 15 2016 - 18:38:37 EST


On Wed, Jun 15, 2016 at 1:49 PM, Emese Revfy <re.emese@xxxxxxxxx> wrote:
> On Wed, 15 Jun 2016 11:07:08 -0700
> Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
>> On Tue, Jun 14, 2016 at 3:20 PM, Emese Revfy <re.emese@xxxxxxxxx> wrote:
>
>> This doesn't look right to me: these are CFLAGS_REMOVE_* entries, and
>> I think you want to _add_ the DISABLE_LATENT_ENTROPY_PLUGIN to the
>> CFLAGS here.
>
> Thanks for the report. I think this patch fixes it:
> https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/commit/e7601ca00a0aeb5f6b96dc79a51a5089c4d32791

Yup, that looks correct, thanks!

-Kees

--
Kees Cook
Chrome OS & Brillo Security