Re: [PATCH] KEYS: potential uninitialized variable

From: David Howells
Date: Thu Jun 16 2016 - 10:50:44 EST


David Howells <dhowells@xxxxxxxxxx> wrote:

> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> If __key_link_begin() failed then "edit" would be uninitialized. I've
> added a check to fix that.
>
> This allows a random user to crash the kernel, though it's quite difficult
> to achieve. There are three ways it can be done as the user would have to
> cause an error to occur in __key_link():
>
> ...

I forgot to mention, this fixes CVE-2016-4470.

David