Re: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks

From: Andy Lutomirski
Date: Thu Jun 16 2016 - 13:21:50 EST


On Thu, Jun 16, 2016 at 4:10 AM, Vladimir Davydov
<vdavydov@xxxxxxxxxxxxx> wrote:
> On Wed, Jun 15, 2016 at 05:28:26PM -0700, Andy Lutomirski wrote:
> ...
>> @@ -225,7 +225,8 @@ static void account_kernel_stack(struct thread_info *ti, int account)
>> {
>> struct zone *zone = page_zone(virt_to_page(ti));
>>
>> - mod_zone_page_state(zone, NR_KERNEL_STACK, account);
>> + mod_zone_page_state(zone, NR_KERNEL_STACK,
>> + THREAD_SIZE / PAGE_SIZE * account);
>
> It won't work if THREAD_SIZE < PAGE_SIZE. Is there an arch with such a
> thread size, anyway? If no, we should probably drop thread_info_cache.

On a quick grep, I can't find any. I'll add a BUILD_BUG_ON for now.

--Andy