Re: [PATCH 1/5] net: qlcnic: don't set unused function argument

From: David Miller
Date: Thu Jun 16 2016 - 20:33:38 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Thu, 16 Jun 2016 13:38:22 +0200

> We get a warning for qlcnic_83xx_get_mac_address when building with
> "make W=1":
>
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c: In function 'qlcnic_83xx_get_mac_address':
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2156:8: error: parameter 'function' set but not used [-Werror=unused-but-set-parameter]
>
> Clearly this is harmless, but there is also no point for setting
> the variable, so we can simply remove the assignment.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied to net-next.