Re: [PATCH] gpio: sx150x: Update OF configuration

From: Linus Walleij
Date: Sat Jun 18 2016 - 05:02:11 EST


On Fri, Jun 17, 2016 at 11:51 AM, Neil Armstrong
<narmstrong@xxxxxxxxxxxx> wrote:

> In case of OF probing, the driver fails to initialize :
> - gpio_chip.base must be -1
> - irq_summary must be either -1 or valid
> - There is no way to use the other configurations
>
> Add OF parsing function to complete the HW configuration, make
> OF configuration dynamic instead of static with #defines and
> update the DT bindings.
>
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>

As you can see from the result of the build robot, the removal
of #ifdef CONFIG_OF_GPIO does not play well with non-DT
configurarions.

You need to figure something out here so that it builds for
both.

Yours,
Linus Walleij