Re: [PATCH 0/6] dell-smm-hwmon fixes

[Pali RohÃr]

On Saturday 18 June 2016 17:13:59 Guenter Roeck wrote:
> On 06/17/2016 03:54 PM, Pali RohÃr wrote:
> > I'm sending all my dell-smm-hwmon patches in one series, because
> > due to changes in code other patches depends on previous.
> > 
> > First two patches fixes problem with old /proc/i8k file. Second is
> > security fix and should be backported to all stable kernels (that
> > problem was there always). I tested i8kctl tool (from i8kutils
> > package) that it still works with these patches. Without root
> > access for those security operations just showes '?' or '-1'.
> > 
> > Third and fourth patches try to fix problem on machines with broken
> > SMM/BIOS when calling function fan_type().
> > 
> > Fifth is new feature and last sixth useful for debugging.
> > 
> > Pali RohÃr (6):
> >    hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when bios
> >    version is
> >    
> >      not a number
> >    
> >    hwmon: (dell-smm) Restrict fan control and serial number to
> >    
> >      CAP_SYS_ADMIN by default
> >    
> >    hwmon: (dell-smm) Disallow fan_type() calls on broken machines
> >    hwmon: (dell-smm) Cache fan_type() calls and change fan
> >    detection hwmon: (dell-smm) Detect fan with index=2
> >    hwmon: (dell-smm) In debug mode log duration of SMM calls
> >   
> >   drivers/hwmon/dell-smm-hwmon.c |  122
> >   ++++++++++++++++++++++++++++++++-------- 1 file changed, 99
> >   insertions(+), 23 deletions(-)
> 
> Pali,
> 
> You asked for additional testing, so I am not sure what you expect me
> to do.
> 
> Which of the patches can/should I apply now ?
> 
> Guenter

Test 3/6 and 4/6 patches on affected Dell machines. I CCed all people 
who tried to debug those bugs, so need confirmation from them that after 
applying 3/6 and 4/6 patches, erratic fan behaviour is not there...

But because those two patches depends on previous, it is needed to test 
whole series...

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.