Re: [PATCH v2 1/3] Documentation: DT: Add iproc-static-adc binding

From: Rob Herring
Date: Mon Jun 20 2016 - 14:05:08 EST


On Sun, Jun 19, 2016 at 03:36:28PM +0530, Raveendra Padasalagi wrote:
> The patch adds devicetree binding document for broadcom's
> iproc-static-adc controller driver.
>
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@xxxxxxxxxxxx>
> Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx>
> Reviewed-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
> ---
> .../bindings/iio/adc/brcm,iproc-static-adc.txt | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
> new file mode 100644
> index 0000000..1de0dfa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt
> @@ -0,0 +1,43 @@
> +* Broadcom's IPROC Static ADC controller
> +
> +Required properties:
> +
> +- compatible: Must be "brcm,iproc-static-adc"
> +

> +- #address-cells: Specify the number of u32 entries needed in child nodes.
> + Should set to 1.
> +
> +- #size-cells: Specify number of u32 entries needed to specify child nodes size
> + in reg property. Should set to 1.

Why are these needed? What child nodes can you have?

> +
> +- adc-syscon: Handler of syscon node defining physical base address of the
> + controller and length of memory mapped region.
> +
> +- #io-channel-cells = <1>; As ADC has multiple outputs
> + refer to Documentation/devicetree/bindings/iio/iio-bindings.txt for details.
> +
> +- clocks: Clock used for this block.
> +
> +- clock-names: Clock name should be given as tsc_clk.
> +
> +- interrupts: interrupt line number.
> +
> +For example:
> +
> + ts_adc_syscon: ts_adc_syscon@180a6000 {
> + compatible = "brcm,iproc-ts-adc-syscon","syscon";
> + reg = <0x180a6000 0xc30>;
> + };
> +
> + adc: adc@180a6000 {
> + compatible = "brcm,iproc-static-adc";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + adc-syscon = <&ts_adc_syscon>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> + clocks = <&asiu_clks BCM_CYGNUS_ASIU_ADC_CLK>;
> + clock-names = "tsc_clk";
> + interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> --
> 1.9.1
>