Re: [PATCH 3/3] iio: potentiometer: mcp4531: Add device tree binding

From: Peter Rosin
Date: Wed Jun 22 2016 - 03:07:15 EST


On 2016-06-22 08:22, Florian Vaussard wrote:
> Hello Peter,
>
> Le 21. 06. 16 à 09:51, Peter Rosin a écrit :
>> That is, if you need this patch at all, see my reply to 2/3...
>>
>
> This seems necessary in order to have the vendor ID in the compatible string.

Hmm, I don't think so. The way I read the response from Rob was that
*my* device tree snippet should not assume that the i2c subsystem
ignores the vendor. So, I think that even w/o this patch a DT entry
like

mcp4651-104@28 {
compatible = "microchip,mcp4651-104";
reg = <0x28>;
};

will work, precisely since i2c ignores the microchip, part (and thus
allows you to omit/misspell it). I.e. I think that Rob is concerned
with how the DT is documented/defined, and not so much about how it
is then implemented in Linux.

I haven't actually tested that though, so I may be completely wrong
in all of the above statements...

Cheers,
Peter