Re: [PATCH] compat: remove compat_printk

From: Arnd Bergmann
Date: Wed Jun 22 2016 - 06:14:03 EST


On Tuesday, June 21, 2016 4:38:57 PM CEST Andrew Morton wrote:
> > @@ -1077,15 +1076,6 @@ static struct ctl_table kern_table[] = {
> > .extra1 = &neg_one,
> > },
> > #endif
> > -#ifdef CONFIG_COMPAT
> > - {
> > - .procname = "compat-log",
> > - .data = &compat_log,
> > - .maxlen = sizeof (int),
> > - .mode = 0644,
> > - .proc_handler = proc_dointvec,
> > - },
> > -#endif
>
> How do we know we can simply remove /proc/sys/kernel/compat-log without
> breaking any userspace?
>

Good point. I guess we can leave this in place just in case (with a comment)
and just remove the compat_printk function. We could probably have a Kconfig
symbol for obsolete sysctl files, but if this is the only one controlled
by it, it's probably not worth the effort.

Arnd