Re: [PATCH 4/4] HID: remove ThingM blink(1) driver

From: Vivien Didelot
Date: Wed Jun 22 2016 - 16:04:11 EST


Hi Heiner,

Heiner Kallweit <hkallweit1@xxxxxxxxx> writes:

>>> Also adding Vivien Didelot to CC, as the author of the original driver.
>>> Vivien, the full set can be found in linux-input archives (
>>> http://marc.info/?l=linux-input&r=1&b=201606&w=2 )
>>
>> Thanks a lot for the follow-up Jiri.
>>
>> If you guys decide to remove hid-thingm.c, you need to update the
>> MAINTAINERS entry, checkpatch.pl should have warned about that.
>>
> Right, thanks for the hint.
>
>> I can hardly test the patchset now. Heiner, can you confirm me that with
>> your patchset, we will still see 3 led_classdev in sysfs for the
>> blink(1) mk1 (which has one RGB chip) and 6 for mk2 (which has 2 chips)?
>>
> Yes, this will still be the case.

Looks good to me then! Please Cc' me in the v2 so I can hack the change.

Thanks,

Vivien