Re: [PATCH] arm64:swiotlb:Enable only when Input size through command line

From: Konrad Rzeszutek Wilk
Date: Thu Jun 23 2016 - 12:08:54 EST


On June 23, 2016 10:30:34 AM EDT, Catalin Marinas <catalin.marinas@xxxxxxx> wrote:
>On Thu, Jun 23, 2016 at 05:43:40PM +0530, Manjeet Pawar wrote:
>> From: Rohit Thapliyal <r.thapliyal@xxxxxxxxxxx>
>>
>> swiotlb default size of 64M is too big as
>> default value therefore it is made configurable
>> through command line through swiotlb_size parameter.
>> swiotlb allocation shall be done only when the
>> swiotlb size is given through command line.
>> Otherwise no swiotlb is allocated.
>
>I already queued this patch:
>
>http://lkml.kernel.org/g/1465372426-4077-1-git-send-email-jszhang@xxxxxxxxxxx
>
>If you have any objections to it, please reply there.


I do (sorry about duplicate email, the other got rejected by mailing lists).

Why not expand the swiotlb= parameter instead of introducing a new one?

Also, why not use the swiotlb by itself? That does the job as well?