Re: [PATCH 4/5] PM / devfreq: make event/exynos-nocp DEVFREQ_EVENT_EXYNOS_NOCP tristate

From: Chanwoo Choi
Date: Sun Jun 26 2016 - 22:40:54 EST


Hi Paul,

On 2016ë 06ì 26ì 03:43, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> event/Kconfig:config DEVFREQ_EVENT_EXYNOS_NOCP
> event/Kconfig: bool "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Rather than rip out the existing modular code, Chanwoo indicated
> that he'd rather see the driver offered as tristate.
>
> I don't have the hardware for runtime validation, so this change
> is only validated for compile and modpost.
>
> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Cc: Kukjin Kim <kgene@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---
> drivers/devfreq/event/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/event/Kconfig b/drivers/devfreq/event/Kconfig
> index 1e8b4f469f38..96ea29d1ede5 100644
> --- a/drivers/devfreq/event/Kconfig
> +++ b/drivers/devfreq/event/Kconfig
> @@ -14,7 +14,7 @@ menuconfig PM_DEVFREQ_EVENT
> if PM_DEVFREQ_EVENT
>
> config DEVFREQ_EVENT_EXYNOS_NOCP
> - bool "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
> + tristate "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
> depends on ARCH_EXYNOS
> select PM_OPP
> help
>

Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

Regards,
Chanwoo Choi