Re: [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer

From: Ingo Molnar
Date: Mon Jun 27 2016 - 07:01:01 EST



* Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote:

> +#define efi_call_virt_pointer(p, f, args...) \
> +({ \
> + efi_status_t __s; \
> + unsigned long flags; \
> + \
> + arch_efi_call_virt_setup(); \
> + \
> + local_save_flags(flags); \
> + __s = arch_efi_call_virt(p, f, args); \
> + efi_call_virt_check_flags(flags, __stringify(f)); \
> + \
> + arch_efi_call_virt_teardown(); \
> + \
> + __s; \
> +})
> +
> +#define __efi_call_virt_pointer(p, f, args...) \
> +({ \
> + unsigned long flags; \
> + \
> + arch_efi_call_virt_setup(); \
> + \
> + local_save_flags(flags); \
> + arch_efi_call_virt(p, f, args); \
> + efi_call_virt_check_flags(flags, __stringify(f)); \
> + \
> + arch_efi_call_virt_teardown(); \
> +})

Note that while at it I renamed 'flags' to '__flags' because 'flags' is
a commonly used variable name and the 'efi_status_t __s' variable was
macro-prefixed already.

Any objections?

Thanks,

Ingo