RE: [PATCH 1/1] regulator: max77620: check for valid regulator info

From: Venkat Reddy Talla
Date: Tue Jun 28 2016 - 00:36:10 EST


> * PGP Signed by an unknown key
>
> On Mon, Jun 27, 2016 at 05:13:44PM +0530, Venkat Reddy Talla wrote:
> > Check for valid regulator information data before configuring FPS
> > source and FPS power up/down period to avoid NULL pointer exception if
> > entries for PMIC regulators not provided through device tree.
>
> This sounds like it's papering over a bug in the driver - the driver should be
> able to instantiate without anything beyond the registration of the device.
> What's the driver relying on from the DT?
>
Sorry for confusion, there is no dependent on DTS entry, I mean, in probe
SD4 regulator for MAX77620 PMIC is not registered with regulator core framework so
Regulator info will be null.

> > SD4 regulator is not supported by MAX77620 PMIC, removing
> > SD4 entry from regulator information list.
>
> This appears to be a separate change to the above and should be a separate
> patch.
>
Regulator info data will be null since SD4 regulator is not getting registered with core framework,
MAX77620 not supporting SD4 regulator, due to this reason I have included this change as part of this patch.
I will change the commit message and push another patch on top of this patch.

Thanks for review.

> * Unknown Key
> * 0x5D5487D0