Re: [PATCH v5 2/3] mfd: lpc_ich: Prepare to split lpc-ich driver

From: Andy Shevchenko
Date: Tue Jun 28 2016 - 04:26:56 EST


On Tue, Jun 28, 2016 at 10:56 AM, Tan Jui Nee <jui.nee.tan@xxxxxxxxx> wrote:
> This patch follows the example of mfd/wm831x and splits it into an
> interface independent core since it is growing quite fast with
> many table entries.

I didn't see a split below. It is just a rename. And actually it would
be better to indeed have rename as a separate change.

>
> Signed-off-by: Tan Jui Nee <jui.nee.tan@xxxxxxxxx>
> ---
> drivers/mfd/Makefile | 1 +
> drivers/mfd/lpc_ich-core.c | 1126 ++++++++++++++++++++++++++++++++++++++++++++
> drivers/mfd/lpc_ich.c | 1126 --------------------------------------------

It can't be reviewed in this form.
Please use parameters (-M, for example) to git format-patch.

--
With Best Regards,
Andy Shevchenko