Re: [PATCH 4/7] reset: Supply *_shared variant calls when using *_optional APIs

From: Lee Jones
Date: Tue Jun 28 2016 - 04:55:44 EST


Philipp,

I need this to go into the -rcs too.

Can I add it with your Ack please?

> Consumers need to be able to specify whether they are requesting an
> 'exclusive' or 'shared' reset line no matter which API (of_*, devm_*,
> etc) they are using. This change allows users of the optional_* API
> in particular to specify that their request is for a 'shared' line.
>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> include/linux/reset.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index fd69240..c358106 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -141,6 +141,12 @@ static inline struct reset_control *reset_control_get_optional_exclusive(
> return __of_reset_control_get(dev ? dev->of_node : NULL, id, 0, 0);
> }
>
> +static inline struct reset_control *reset_control_get_optional_shared(
> + struct device *dev, const char *id)
> +{
> + return __of_reset_control_get(dev ? dev->of_node : NULL, id, 0, 1);
> +}
> +
> /**
> * of_reset_control_get_exclusive - Lookup and obtain an exclusive reference
> * to a reset controller.
> @@ -270,6 +276,12 @@ static inline struct reset_control *devm_reset_control_get_optional_exclusive(
> return __devm_reset_control_get(dev, id, 0, 0);
> }
>
> +static inline struct reset_control *devm_reset_control_get_optional_shared(
> + struct device *dev, const char *id)
> +{
> + return __devm_reset_control_get(dev, id, 0, 1);
> +}
> +
> /**
> * devm_reset_control_get_exclusive_by_index - resource managed
> * reset_control_get_exclusive()

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog