Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

From: David Miller
Date: Tue Jun 28 2016 - 05:34:23 EST


From: Dexuan Cui <decui@xxxxxxxxxxxxx>
Date: Fri, 24 Jun 2016 07:45:24 +0000

> + while ((ret = vmalloc(size)) == NULL)
> + ssleep(1);

This is completely, and entirely, unacceptable.

If the allocation fails, you return an error and release
your resources.

You don't just loop forever waiting for it to succeed.