Re: [PATCH v3 2/2] remoteproc: qcom: Introduce WCNSS peripheral image loader

From: Bjorn Andersson
Date: Tue Jun 28 2016 - 17:22:28 EST


On Tue 28 Jun 14:05 PDT 2016, Arnd Bergmann wrote:

> On Tuesday, June 28, 2016 1:58:26 PM CEST Bjorn Andersson wrote:
> >
> > +config QCOM_WCNSS_PIL
> > + tristate "Qualcomm WCNSS Peripheral Image Loader"
> > + depends on OF && ARCH_QCOM
> > + select QCOM_MDT_LOADER
> > + select QCOM_SCM
> > + select REMOTEPROC
> > + help
> > + Say y here to support the Peripherial Image Loader for the Qualcomm
> > + Wireless Connectivity Subsystem.
> > +
> >
>
> "depends on QCOM_SMEM"
>
> This showed up in Linux-next today and caused a build error:
>
> drivers/remoteproc/built-in.o: In function `q6v5_fatal_interrupt':
> qcom_q6v5_pil.c:(.text+0x2428): undefined reference to `qcom_smem_get'
> drivers/remoteproc/built-in.o: In function `q6v5_wdog_interrupt':
> qcom_q6v5_pil.c:(.text+0x2498): undefined reference to `qcom_smem_get'
>

I was convinced I had stubs for those, sorry for not making sure. I
amended rproc-next with this.

Thanks,
Bjorn